FarmMapsApiClient_KB34_MAST/FarmmapsKPI/TODO.txt

TODO.txt

###################################################################################################
# 1. DONE
###################################################################################################
Laat de farmmapsKPI zelf maar uitzoeken wat de n-p gehaltes zijn:
a.	We willen als input opgeven we hebben 400 kg/ha urea gegeven, of 32000 kg/ha runderdrijfmest. 
    Daarvoor wel de juiste gewas  code opgeven -> zie onder, FarmmapsEditeeltList 263 gewassen
    Daarvoor wel de juiste meststof code opgeven -> zie onder, FarmmapsEditeeltList 022 meststoffen
b.	Check of de operation data een element <20>n<EFBFBD> bevat. Zoniet of als waarde 0, dan
    i.	Zoek onder de motorkap op: de omreken factor (bijv 200 kg/ha urea met 46% n -> 200*0.46 = 92 kg N/ha)
    ii.	Voeg die 92 toe aan de operation data ("n": 92)
c.	Reken N surplus uit (KPI item id b1)
GEPARKEERD: 
    Want voor veel meststoffen is geen content bekend -> automatisch opzoeken zal in veel gevallen niet goed werken
    Laat de gebruiker zelf maar de codelist CL022 raadplegen en omrekenen. 

Nieuw project: FarmmapsEditeeltLists DONE
a. Why? Because 
    i.  This is (1) so that we can at any time retrieve the most recent up-to-date list
    ii. so that you can look up crops and fertilizer types and fill in KPIinput.json correctly
b.	Download full list of items from vnd.farmmaps.itemtype.codelist.cl263 DONE
c.	Write them to a csv file DONE
d.	In any case following lists: 127 operations DONE; 022 meststoffen (fertilizer products) DONE; 263 gewassen DONE; 405 soilcode DONE
    in which list the productionPurposeCode 251 DONE

Testing: 
Effect of soiltype (e.g. different N concents in crop depending on soiltype? (CL405))
    DONE (using KPIinput.json): same N balance, different target & threshold
Effect of location (e.g. different atmospheric N deposition).
    DONE (using KPIinput.json): slightly different N balance

    "DataCropfieldCharacteristic": {
      "code": "860619", //PO20231004: so what does this code mean? Can we see the code list somewhere? COMPLETED code comes from codelist CL265. 860619 refers to cropyield in ton/ha
productionPurposeCode: different result depending on starch or consumption potato (different N contents in tubers)?
    nContentFactor seems not to be adjusted by productionPurposeCode. Tamara check with Francisco
    idem for pContentFactor
    DONE (using KPIinput.json): surprisingly no effect?, format of the productionPurposeCode was wrong i.e was '002' instead of '2'. Format has been adjusted.
dataOperations: "operationCode": "7" & "8": DONE
    a. which codelist? What does it mean? this refers to CL018 (bewerkinghoofdcaterogie), which contains information about the caterogie of the crop operations. 
    7 stands for fertilization while 8 refers to crop protection
    b. using KPIinput.json: does it have an effect on KPI outcomes? YES
dataOperations: "status": "3": DONE
    a. which codelist? What does it mean? this refers to CL256 (statusBewerking), which contains information about  a crop operation has been planned, completed, cancelled etc. 3 refers to completed
    b. using KPIinput.json: does it have an effect on KPI outcomes? NO, even without the status the crop operations is included in the KPI calculation. 
    As the status has no effect on the KPI calculations I have changed the lines about the status in the KPIinput.json file to comment

KPIelementsOfBalance: Tamara
    a. define elements for C1 organic matter supply
    b. for nitrogen B1 rename disposal to nHarvestedNKgHa COMPLETED
    c. for phosporous B2 rename disposal to pHarvestedPKgHa COMPLETED 
    d. for phosporous B2 rename from pFertilizerNKgHa to pFertilizerPKgHa COMPLETED
    e. idem sowPlantingNKgHa COMPLETED
    f. add straw for N & P in output COMPLETED
    g. add 2 examples in KPIinput.json: straw yes/no removed. Bijv. nStrawLeftInField EN nStrawRemoved COMPLETED
    h. add amount of removed straw in A1 COMPLETED
    i. update KPIdefinitions.csv COMPLETED

###################################################################################################
# 2. Pending
###################################################################################################
Testing: 

KPIelementsOfBalance: Tamara
    j. for C1 rename 'cropLeftoversEom' to 'cropResiduesEom' GEPARKEERD