AW-3477 fmHasPackage check werkt niet correct voor vandaag

Jenkinsfile

@@ -8,13 +8,13 @@ pipeline {
     stage('npm install'){
       steps {
         sh '''rm -rf node_modules/
-        npm install
+        npm install --legacy-peer-deps
         cd projects/common
-        npm install
+        npm install --legacy-peer-deps
         cd ../common-map
-        npm install
+        npm install --legacy-peer-deps
         cd ../common-map3d
-        npm install
+        npm install --legacy-peer-deps
         '''
       }
     }

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "farmmaps-lib-app",
-  "version": "1.1.1",
+  "version": "1.1.13",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
@@ -4079,25 +4079,25 @@
       "dev": true
     },
     "@farmmaps/common": {
-      "version": "1.1.1-prerelease.2031",
-      "resolved": "https://repository.akkerweb.nl/repository/npm-group/@farmmaps/common/-/common-1.1.1-prerelease.2031.tgz",
-      "integrity": "sha512-lSmTd2D1/PqzaXBjjY4X6UTYA5joZndXyZpUkFNm/Z0TTFmzFKmiIyGRA9AHX4StdQXC7QsCNfalYN31tnwtuQ==",
+      "version": "1.1.12",
+      "resolved": "https://repository.akkerweb.nl/repository/npm-group/@farmmaps/common/-/common-1.1.12.tgz",
+      "integrity": "sha512-TqPyPv35wK4bM1D/ZnT7zmno12pIlmBVesMKMJF7VtddZUm9mZe890ZQv7JJrbgURhU1o4mBs2ytmW0dGhDArw==",
       "requires": {
         "tslib": "^2.0.0"
       }
     },
     "@farmmaps/common-map": {
-      "version": "1.1.1-prerelease.2031",
-      "resolved": "https://repository.akkerweb.nl/repository/npm-group/@farmmaps/common-map/-/common-map-1.1.1-prerelease.2031.tgz",
-      "integrity": "sha512-BQ2bvNohPth0+oxoSoh+WWLJ/mP2CGW4Qf4xqgC3tgfW+UZfD0dBPl7IT2piuvOuUQzlSVloinCJ4ciZGyZRXg==",
+      "version": "1.1.12",
+      "resolved": "https://repository.akkerweb.nl/repository/npm-group/@farmmaps/common-map/-/common-map-1.1.12.tgz",
+      "integrity": "sha512-mu2AaIrGEbfj7gzJZLwLwBawOWwz4cJXDxcrsZQRzTb8Z9BA3ZV+9w1XkGU7Q0CgYLPuGaWMFF6AHqzTPARj/g==",
       "requires": {
         "tslib": "^2.0.0"
       }
     },
     "@farmmaps/common-map3d": {
-      "version": "1.1.1-prerelease.2031",
-      "resolved": "https://repository.akkerweb.nl/repository/npm-group/@farmmaps/common-map3d/-/common-map3d-1.1.1-prerelease.2031.tgz",
-      "integrity": "sha512-2M5wv5sFwlVwPGlN1b1AGM3Dh/DJFS7+L3b6e6ir2+ASoyy7xhZ67IWS2du8B7y7/xVsgxCJcJp1EJezbSCMAA==",
+      "version": "1.1.12",
+      "resolved": "https://repository.akkerweb.nl/repository/npm-group/@farmmaps/common-map3d/-/common-map3d-1.1.12.tgz",
+      "integrity": "sha512-yHRrL97GQZj0m4AlhsNrnKL6aujCBr5qgbp7uiUqsSQXp2dpJXbUFZpPnPKvOrFDUNJl8gqsbo5cvsvHucqCYg==",
       "requires": {
         "tslib": "^2.0.0"
       }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "farmmaps-lib-app",
-  "version": "1.1.1",
+  "version": "1.1.13",
   "scripts": {
     "ng": "ng",
     "start": "ng serve",
@@ -19,9 +19,9 @@
     "@angular/platform-browser": "~11.2.14",
     "@angular/platform-browser-dynamic": "~11.2.14",
     "@angular/router": "~11.2.14",
-    "@farmmaps/common": "1.1.1-prerelease.2031",
-    "@farmmaps/common-map": "1.1.1-prerelease.2031",
-    "@farmmaps/common-map3d": "1.1.1-prerelease.2031",
+    "@farmmaps/common": "1.1.12",
+    "@farmmaps/common-map": "1.1.12",
+    "@farmmaps/common-map3d": "1.1.12",
     "@microsoft/signalr": "^3.1.16",
     "@ng-bootstrap/ng-bootstrap": "^9.0",
     "@ngrx/effects": "^11.0",

projects/common-map/src/fm-map/common-map.module.ts

@@ -19,6 +19,7 @@ import * as mapEffects from './effects/map.effects';
 import { IMapState} from './models/map.state';
 import { ISelectedFeatures } from './models/selected.features';
 import { IItemLayer,ItemLayer,ITemporalItemLayer,TemporalItemLayer } from './models/item.layer';
+import { IClickedFeature } from './models/clicked.feature';
 import { IPeriodState } from './models/period.state';
 
 // components
@@ -163,7 +164,9 @@ export {
   ITemporalItemLayer,
   TemporalItemLayer,
   ifZoomToShowDirective,
-  ZoomToShowAlert
+  ZoomToShowAlert,
+  IClickedFeature,
+  GeometryThumbnailComponent
 }
 
 @NgModule({
@@ -273,7 +276,8 @@ export {
        FeatureListFeatureContainerComponent,
        ZoomToExtentComponent,
        ifZoomToShowDirective,
-       ZoomToShowAlert
+       ZoomToShowAlert,
+      GeometryThumbnailComponent
   ],
   providers: [
     FeatureIconService,

projects/common-map/src/fm-map/components/feature-list-container/feature-list-container.component.ts

@@ -38,7 +38,7 @@ export class FeatureListContainerComponent {
       let criteria=0;
       if (this.featureLists[i]['forItemType']) {
         criteria++;
-        if( this.featureLists[i]['forItemType'].indexOf(queryState.itemType) >= 0) {
+        if( this.featureLists[i]['forItemType'].split(",").filter(part => part == queryState.itemType).length == 1) {
           matches++;
         }
       }

projects/common-map/src/fm-map/components/feature-list-feature-container/feature-list-feature-container.component.ts

@@ -32,7 +32,7 @@ export class FeatureListFeatureContainerComponent {
       let criteria=0;
       if (this.featureLists[i]['forItemType']) {
         criteria++;
-        if(this.featureLists[i]['forItemType'].indexOf(this.feature.get("itemType")) >= 0) {
+        if(this.featureLists[i]['forItemType'].split(",").filter(part => part == this.feature.get("itemType")).length == 1) {
           matches++;
         }
       }         

projects/common-map/src/fm-map/components/feature-thumbnail/feature-thumbnail.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, OnInit,ViewChild } from '@angular/core';
+import { Component, Input, AfterViewInit, ViewChild } from '@angular/core';
 import { Feature} from 'ol';
 import { Geometry } from 'ol/geom';
 import * as extent from 'ol/extent';
@@ -10,23 +10,54 @@ import * as style from 'ol/style';
   templateUrl: './feature-thumbnail.component.html',
   styleUrls: ['./feature-thumbnail.component.scss']
 })
-export class GeometryThumbnailComponent implements OnInit {
+export class GeometryThumbnailComponent implements AfterViewInit {
+
 
   constructor() { }
 
   @ViewChild('canvas') canvas;
   @ViewChild('container') container;
-  @Input('feature') feature:Feature;
 
-  ngOnInit(): void {
+  private geometry:Geometry = null;
+  @Input() set feature(value:Feature) {
+    if(value) {
+      this.geometry = value.getGeometry();
+    } else {
+      this.geometry = null;
     }
+    this.render(this.canvas,
+      this.geometryStyle,
+      this.geometry,
+      this.width, 
+      this.height);
+  };
 
-  render(canvas,width,height,geometry:Geometry) {  
-    let renderContext = render.toContext(canvas.getContext( '2d'),{ size: [width, height] });  
-   
-    let strokeStyle  = new style.Style({
+  private defaultStyle:style.Style = new style.Style({
     stroke: new style.Stroke({ color: 'black',width:1.5 })
   });  
+  private geometryStyle:style.Style = this.defaultStyle;
+  @Input() set fillColor(value:string) {
+    if(style) {
+      this.geometryStyle = new style.Style({
+        stroke: new style.Stroke({ color: 'black',width:1.5 }),
+        fill: new style.Fill({color: value})
+      });  
+    } else {
+      this.geometryStyle = this.defaultStyle
+    }
+    this.render(this.canvas,
+      this.geometryStyle,
+      this.geometry,
+      this.width, 
+      this.height);
+  }
+
+  private width:number = 0;
+  private height:number = 0;
+
+  render(canvas,style:style.Style,geometry:Geometry,width:number,height:number) {  
+    if(canvas && canvas.nativeElement && geometry && style) {
+      let renderContext = render.toContext(canvas.nativeElement.getContext( '2d'),{ size: [width, height] });  
 
       let geom   = geometry.clone(),
       line   = geom.getCoordinates()[0],
@@ -45,16 +76,20 @@ export class GeometryThumbnailComponent implements OnInit {
   
       geom.translate( -dx, -dy );
       geom.scale( Math.min(sx, sy), -Math.min(sx, sy));
-    geom.translate( width / 2, height / 2 );
-
-    renderContext.setStyle( strokeStyle );  
+      geom.translate(width / 2,height / 2 );
+      renderContext.setStyle( style );  
       renderContext.drawGeometry( geom );
     }
+  }
 
   ngAfterViewInit() {
-    this.render(this.canvas.nativeElement,
-      this.container.nativeElement.offsetWidth, 
-      this.container.nativeElement.offsetHeight,
-      this.feature.getGeometry());
+    this.width = this.container.nativeElement.offsetWidth;
+    this.height = this.container.nativeElement.offsetHeight;
+    this.render(this.canvas,
+      this.geometryStyle,
+      this.geometry,
+      this.width, 
+      this.height);
   }  
+
 }

projects/common-map/src/fm-map/components/item-list-item-container/item-list-item-container.component.ts

@@ -33,13 +33,13 @@ export class ItemListItemContainerComponent {
       let criteria=0;
       if (this.itemComponentList[i]['forItemType']) {
         criteria++;
-        if(this.itemComponentList[i]['forItemType'].indexOf(this.item.itemType) >= 0) {
+        if(this.itemComponentList[i]['forItemType'].split(",").filter(part => part ==this.item.itemType).length == 1) {
           matches++;
         }
       }
       if (this.itemComponentList[i]['forSourceTask']) {
         criteria++;
-        if(this.itemComponentList[i]['forSourceTask'].indexOf(this.item.sourceTask) >= 0) {
+        if(this.itemComponentList[i]['forSourceTask'].split(",").filter(part => part ==this.item.sourceTask).length ==1) {
           matches++;
         }
       }

projects/common-map/src/fm-map/components/map/map.component.html

@@ -74,7 +74,7 @@
         </div>  
       </fm-side-panel>
       <fm-side-panel [resizeable]="true" [visible]="!noContent">
-        <router-outlet></router-outlet>
+        <router-outlet (activate)="handleSidepaneloutletActivate($event)" (deactivate)="handleSidepaneloutletDeactivate($event)"></router-outlet>
       </fm-side-panel>
     </div>   
   </aol-map>  

projects/common-map/src/fm-map/components/map/map.component.ts

@@ -11,6 +11,7 @@ import { DeviceService } from '@farmmaps/common';
 import * as mapReducers from '../../reducers/map.reducer';
 import * as mapActions from '../../actions/map.actions';
 import { IMapState} from '../../models/map.state';
+import { IClickedFeature} from '../../models/clicked.feature';
 import { IQuery } from '../../reducers/map.reducer'
 import { ISelectedFeatures } from '../../models/selected.features';
 import { IItemLayer } from '../../models/item.layer';
@@ -175,6 +176,18 @@ export class MapComponent implements OnInit, OnDestroy,AfterViewInit {
     this.store.dispatch(new mapActions.DoQuery(queryState));
   }
 
+  handleSidepaneloutletActivate(component:any) {
+   if(component && component.hasOwnProperty('clickedFeature')) {
+     (component as IClickedFeature).clickedFeature = this.clickedFeature;
+   }
+  }
+
+  handleSidepaneloutletDeactivate(component:any) {
+    if(component && component.hasOwnProperty('clickedFeature')) {
+      (component as IClickedFeature).clickedFeature = null;
+    }
+  }
+
   ngOnInit() {    
     this.initialized = false;
     console.debug("Init");

projects/common-map/src/fm-map/components/selected-item-container/selected-item-container.component.ts

@@ -34,13 +34,13 @@ export class SelectedItemContainerComponent {
       let criteria=0;
       if (this.selectedItemComponents[i]['forItemType'] ) {
         criteria++;
-        if(this.selectedItemComponents[i]['forItemType'].indexOf(this.item.itemType) >= 0) {
+        if(this.selectedItemComponents[i]['forItemType'].split(",").filter(part => part ==this.item.itemType).length == 1) {
           matches++;
         }
       }
       if (this.selectedItemComponents[i]['forSourceTask']) {
         criteria++;
-        if( this.selectedItemComponents[i]['forSourceTask'].indexOf(this.item.sourceTask) >= 0) {
+        if( this.selectedItemComponents[i]['forSourceTask'].split(",").filter(part => part ==this.item.sourceTask).length == 1) {
           matches++;
         }
       }

projects/common-map/src/fm-map/models/clicked.feature.ts

@@ -0,0 +1,10 @@
+import {Feature} from 'ol';
+import {Geometry} from 'ol/geom';
+import { Observable } from 'rxjs';
+
+/**
+ * @deprecated This interface will be removed soon
+ */
+export interface IClickedFeature  {
+    clickedFeature: Observable<Feature<Geometry>> 
+}

projects/common/src/fm/components/app-menu/app-menu.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { AppMenuComponent } from './app-menu.component';
-
-describe('AppMenuComponent', () => {
-  let component: AppMenuComponent;
-  let fixture: ComponentFixture<AppMenuComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ AppMenuComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(AppMenuComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/components/avatar/avatar.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { AvatarComponent } from './avatar.component';
-
-describe('AvatarComponent', () => {
-  let component: AvatarComponent;
-  let fixture: ComponentFixture<AvatarComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ AvatarComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(AvatarComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/components/edit-image-modal/edit-image-modal.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { EditImageModalComponent } from './edit-image-modal.component';
-
-describe('EditImageModalComponent', () => {
-  let component: EditImageModalComponent;
-  let fixture: ComponentFixture<EditImageModalComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ EditImageModalComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(EditImageModalComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/components/gradient-select/gradient-select.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { GradientSelectComponent } from './gradient-select.component';
-
-describe('GradientSelectComponent', () => {
-  let component: GradientSelectComponent;
-  let fixture: ComponentFixture<GradientSelectComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ GradientSelectComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(GradientSelectComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/components/gradient/gradient.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { GradientComponent } from './gradient.component';
-
-describe('GradientComponent', () => {
-  let component: GradientComponent;
-  let fixture: ComponentFixture<GradientComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ GradientComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(GradientComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/components/has-package/has-package.directive.ts

@@ -1,61 +1,61 @@
-import { Directive, ViewContainerRef,TemplateRef,OnInit,Input,OnDestroy } from '@angular/core';
-import { Store} from '@ngrx/store';
-import * as appCommonReducer from '../../reducers/app-common.reducer'
-import { IPackages } from '../../models/package';
-import { Observable, Subscription } from 'rxjs';
+import {AfterViewInit, Directive, Input, OnDestroy, TemplateRef, ViewContainerRef} from '@angular/core';
+import {Subscription} from 'rxjs';
+import {PackageService} from '../../services/package.service';
+import * as appCommonReducer from '../../reducers/app-common.reducer';
+import {Store} from '@ngrx/store';
 
 @Directive({
   selector: '[fmHasPackage]',
 })
-export class HasPackageDirective  implements OnDestroy{
+export class HasPackageDirective implements OnDestroy, AfterViewInit {
+
   @Input()
-  set fmHasPackage(packageIdentifier:string) {
-    this.packageIdentifier$ = packageIdentifier;
+  set fmHasPackage(packageIdentifier: string) {
+    this.packageIdentifier = packageIdentifier;
     this.updateView();
   }
 
   @Input()
-  set fmHasPackageThen(thenTemplate:TemplateRef<any>) {
-    this.thenTemplate$ = thenTemplate;
+  set fmHasPackageThen(thenTemplate: TemplateRef<any>) {
+    this.thenTemplate = thenTemplate;
     this.updateView();
   }
 
   @Input()
-  set fmHasPackageElse(thenTemplate:TemplateRef<any>) {
-    this.elseTemplate$ = thenTemplate;
+  set fmHasPackageElse(thenTemplate: TemplateRef<any>) {
+    this.elseTemplate = thenTemplate;
     this.updateView();
   }
 
-  private packageIdentifier$:string;
-  private thenTemplate$:TemplateRef<any>;
-  private elseTemplate$:TemplateRef<any>;
-  private packages$:any = {};
-  private packagesObservable$:Observable<IPackages> = this.store$.select(appCommonReducer.SelectGetUserPackages);
-  private packSub:Subscription;
+  private packageIdentifier: string;
+  private thenTemplate: TemplateRef<any>;
+  private elseTemplate: TemplateRef<any>;
+  private packSub: Subscription;
 
-  constructor(private templateRef$: TemplateRef<any>,private viewContainerRef$: ViewContainerRef,private store$: Store<appCommonReducer.State>) { 
-    this.thenTemplate$=templateRef$;
-    this.packSub = this.store$.select(appCommonReducer.SelectGetUserPackages).subscribe((packages) => {
-      this.packages$ = packages;
+  constructor(private hostTemplateRef: TemplateRef<any>, private viewContainerRef: ViewContainerRef,
+              private store: Store<appCommonReducer.State>, private packageService: PackageService) {
+    this.thenTemplate = hostTemplateRef;
+    this.packSub = this.store.select(appCommonReducer.SelectGetValidUserPackages).subscribe((_) => {
       this.updateView();
     });
+  }
+
+  ngAfterViewInit() {
     this.updateView();
   }
 
-
   updateView() {
-    this.viewContainerRef$.clear();
-    const today = new Date(new Date(Date.now()).toUTCString()).setHours(0, 0, 0, 0);
-    if (this.packages$[this.packageIdentifier$] &&
-      (this.packages$[this.packageIdentifier$].dataDate && new Date(this.packages$[this.packageIdentifier$].dataDate).setHours(0, 0, 0, 0) <= today) &&
-      (this.packages$[this.packageIdentifier$].dataEndDate == null || new Date(this.packages$[this.packageIdentifier$].dataEndDate).setHours(0, 0, 0, 0) >= today)) {
-      this.viewContainerRef$.createEmbeddedView(this.thenTemplate$);
-    } else if (this.elseTemplate$) {
-      this.viewContainerRef$.createEmbeddedView(this.elseTemplate$);
+    this.viewContainerRef.clear();
+    if (this.packageService.hasPackage(this.packageIdentifier)) {
+      this.viewContainerRef.createEmbeddedView(this.thenTemplate);
+    } else if (this.elseTemplate) {
+      this.viewContainerRef.createEmbeddedView(this.elseTemplate);
     }
   }
 
   ngOnDestroy() {
-    if(this.packSub) this.packSub.unsubscribe();
+    if (this.packSub) {
+      this.packSub.unsubscribe();
+    }
   }
 }

projects/common/src/fm/components/help-menu/help-menu.component.html

@@ -1,4 +1,4 @@
-<div>
+<div class="mobile-hide">
     <div   (click)="toggle($event)" class="rounded-circle menu-button hidden"  [ngClass]="{'hidden':!user || noContent}">
         <span i18n-title title="Help"><i class="fas fa-question" aria-hidden="true"></i></span>
         <div class="menu hidden" [ngClass]="{'hidden':!showMenu}">                                     

projects/common/src/fm/components/help-menu/help-menu.component.scss

@@ -68,6 +68,16 @@ div.menu-button > span {
     }
 }    
 
+.mobile-hide {
+    display: inherit;
+}
+
+@media screen and (max-width: 768px) {
+    .mobile-hide {
+        display: none;
+    }
+}
+
 .unread {
     display: block;
     position: absolute;

projects/common/src/fm/components/help-menu/help-menu.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { HelpMenuComponent } from './help-menu.component';
-
-describe('HelpMenuComponent', () => {
-  let component: HelpMenuComponent;
-  let fixture: ComponentFixture<HelpMenuComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ HelpMenuComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(HelpMenuComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/components/notification-menu/notification-menu.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { NotificationMenuComponent } from './notification-menu.component';
-
-describe('NotificationMenuComponent', () => {
-  let component: NotificationMenuComponent;
-  let fixture: ComponentFixture<NotificationMenuComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ NotificationMenuComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(NotificationMenuComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/components/user-menu/user-menu.component.spec.ts

@@ -1,25 +0,0 @@
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { UserMenuComponent } from './user-menu.component';
-
-describe('UserMenuComponent', () => {
-  let component: UserMenuComponent;
-  let fixture: ComponentFixture<UserMenuComponent>;
-
-  beforeEach(async(() => {
-    TestBed.configureTestingModule({
-      declarations: [ UserMenuComponent ]
-    })
-    .compileComponents();
-  }));
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(UserMenuComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

projects/common/src/fm/models/package.ts

@@ -7,5 +7,5 @@ export interface IPackage {
 }
 
 export interface IPackages {
-    [id: string]: IPackage;
+    [id: string]: IPackage[];
 }

projects/common/src/fm/reducers/app-common.reducer.ts

@@ -8,6 +8,7 @@ import { createSelector, createFeatureSelector, ActionReducerMap } from '@ngrx/s
 
 import { MODULE_NAME } from '../module-name';
 import { IItem } from '../models/item';
+import {getValidPackages, isValidPackage} from '../services/package.service';
 
 export interface State {
   openedModalName: string,
@@ -131,7 +132,10 @@ export function reducer(state = initialState, action: appCommonActions.Actions )
       a.items.forEach((item) => {
         item.data.dataDate = item.dataDate;
         item.data.dataEndDate = item.dataEndDate;
-        packages[item.data.id]=item.data;
+        if (!packages[item.data.id]) {
+          packages[item.data.id] = [];
+        }
+        packages[item.data.id].push(item.data);
       });
 
       return tassign(state,{userPackages:packages});
@@ -203,6 +207,9 @@ export const selectGetRouteLoading = createSelector(selectAppCommonState, getRou
 export const SelectGetMenuVisible = createSelector(selectAppCommonState,getMenuVisible);
 export const SelectGetUser = createSelector(selectAppCommonState,getUser);
 export const SelectGetUserPackages = createSelector(selectAppCommonState,getUserPackages);
+export const SelectGetValidUserPackages = createSelector(SelectGetUserPackages, (packageMap) => {
+  return getValidPackages(packageMap);
+});
 export const SelectGetUserSettingsRoot = createSelector(selectAppCommonState,getUserSettingsRoot);
 export const SelectGetAccountMenuVisible = createSelector(selectAppCommonState,getAccountMenuVisible);
 export const SelectGetAppMenuVisible = createSelector(selectAppCommonState,getAppMenuVisible);
@@ -213,3 +220,4 @@ export const SelectgetUnreadNotifications = createSelector(selectAppCommonState,
 export const SelectGetIsOnline = createSelector(selectAppCommonState,getIsOnline);
 export const SelectGetIsPageMode = createSelector(selectAppCommonState,getIsPageMode);
 
+

projects/common/src/fm/services/package.service.spec.ts

@@ -0,0 +1,122 @@
+import {getValidPackages, isValidPackage, PackageService} from './package.service';
+import {MockStore, provideMockStore} from '@ngrx/store/testing';
+import {TestBed} from '@angular/core/testing';
+import * as appCommonReducer from '../reducers/app-common.reducer';
+import {reducer, State} from '../reducers/app-common.reducer';
+import * as appCommonActions from '../actions/app-common.actions';
+import {IItem} from '../models/item';
+import {IPackage} from '../models/package';
+
+describe('PackageService', () => {
+  const initialState = {userPackages: {}} as State;
+  let serviceUnderTest: PackageService;
+  let items;
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      providers: [
+        provideMockStore({
+          initialState,
+          selectors: [
+            {
+              selector: appCommonReducer.SelectGetValidUserPackages,
+              value: {
+                'vnd.farmmaps.package.zoning': {
+                  id: 'vnd.farmmaps.package.zoning',
+                  name: 'zoning package',
+                  dataDate: '2022-01-25T00:00:00.000000Z'
+                }
+              }
+            }
+          ]
+        }),
+      ]
+    });
+
+    const store = TestBed.inject(MockStore);
+    serviceUnderTest = new PackageService(store, null, null);
+
+    items = [
+      {
+        code: '123132',
+        dataDate: '2021-01-25T00:00:00Z',
+        dataEndDate: '2021-05-25T00:00:00Z',
+        data: {
+          id: 'vnd.farmmaps.package.zoning'
+        }
+      } as IItem,
+      {
+        code: '1231325',
+        dataDate: '2021-01-25T00:00:00Z',
+        dataEndDate: null,
+        data: {
+          id: 'vnd.farmmaps.package.zoning'
+        }
+      } as IItem,
+      {
+        code: '1231325',
+        dataDate: '2022-01-25T00:00:00Z',
+        dataEndDate: '2022-05-25T00:00:00Z',
+        data: {
+          id: 'vnd.farmmaps.package.tipstar'
+        }
+      } as IItem,
+      {
+        code: '1231325',
+        dataDate: '2022-01-25T00:00:00Z',
+        dataEndDate: null,
+        data: {
+          id: 'vnd.farmmaps.package.weather'
+        }
+      } as IItem
+    ];
+  });
+
+  it('Does not have a tipstar package', () => {
+    const hasPackage = serviceUnderTest.hasPackage('vnd.farmmaps.package.tipstar');
+    expect(hasPackage).toBe(false);
+  });
+
+  it('Does have a zoning package', () => {
+    const hasPackage = serviceUnderTest.hasPackage('vnd.farmmaps.package.zoning');
+    expect(hasPackage).toBe(true);
+  });
+
+  it('reducer.INITUSERPACKAGESSUCCESS alter state correctly', () => {
+    const action = new appCommonActions.InitUserPackagesSuccess(items);
+
+    expect(Object.keys(initialState.userPackages).length).toBe(0);
+    const state = reducer(initialState, action);
+    expect(Object.keys(state.userPackages).length).toBe(3);
+    expect(state.userPackages['vnd.farmmaps.package.zoning'].length).toBe(2);
+    expect(state.userPackages['vnd.farmmaps.package.tipstar'].length).toBe(1);
+    expect(state.userPackages['vnd.farmmaps.package.weather'].length).toBe(1);
+  });
+
+  it('to validatePackage', () => {
+    const action = new appCommonActions.InitUserPackagesSuccess(items);
+    const state = reducer(initialState, action);
+
+    expect(isValidPackage(null)).toBe(false);
+    expect(isValidPackage(state.userPackages['vnd.farmmaps.package.tipstar'][0])).toBe(true);
+    expect(isValidPackage(state.userPackages['vnd.farmmaps.package.zoning'][0])).toBe(false);
+    expect(isValidPackage(state.userPackages['vnd.farmmaps.package.zoning'][1])).toBe(true);
+    expect(isValidPackage(state.userPackages['vnd.farmmaps.package.weather'][0])).toBe(true);
+  });
+
+  it('to getValidPackages', () => {
+    const action = new appCommonActions.InitUserPackagesSuccess(items);
+    const state = reducer(initialState, action);
+
+    const validPackages = getValidPackages(state.userPackages);
+
+    expect(Object.keys(validPackages).length).toBe(3);
+
+    // today is 27-01-2022, so the below package is not valid
+    expect(validPackages['vnd.farmmaps.package.zoning']).not.toEqual({
+      id: 'vnd.farmmaps.package.zoning',
+      dataDate: '2021-01-25T00:00:00Z',
+      dataEndDate: '2021-05-25T00:00:00Z'
+    } as unknown as IPackage);
+  });
+});

projects/common/src/fm/services/package.service.ts

@@ -1,37 +1,58 @@
-import { Injectable } from '@angular/core';
-import { Store} from '@ngrx/store';
-import * as appCommonReducer from '../reducers/app-common.reducer'
-import { IPackages } from '../models/package';
+import {Injectable} from '@angular/core';
+import {Store} from '@ngrx/store';
+import * as appCommonReducer from '../reducers/app-common.reducer';
+import {IPackage, IPackages} from '../models/package';
 
-import { IItem } from '../models/item';
-import { IItemTask } from '../models/itemTask';
-import { HttpClient } from "@angular/common/http";
-import { AppConfig } from "../shared/app.config";
-import { Observable } from 'rxjs';
+import {IItem} from '../models/item';
+import {IItemTask} from '../models/itemTask';
+import {HttpClient} from '@angular/common/http';
+import {AppConfig} from '../shared/app.config';
+import {Observable} from 'rxjs';
 
 @Injectable({
   providedIn: 'root',
 })
 
 export class PackageService {
-    private packages$:IPackages = {};
+  private packages: { [key: string]: IPackage } = {};
 
   constructor(private store$: Store<appCommonReducer.State>, public httpClient: HttpClient, public appConfig: AppConfig) {
-        store$.select(appCommonReducer.SelectGetUserPackages).subscribe((packages) => {
-            this.packages$ = packages;
-        })
+    store$.select(appCommonReducer.SelectGetValidUserPackages).subscribe((packages) => {
+      this.packages = packages;
+    });
   }
 
   ApiEndpoint() {
-        return this.appConfig.getConfig("apiEndPoint");
+    return this.appConfig.getConfig('apiEndPoint');
   }
 
-    hasPackage(id:string):boolean {
-       if(!this.packages$[id]) return false;
-       return this.packages$[id].enabled ? this.packages$[id].enabled == true : true;
+  hasPackage(id: string): boolean {
+    return id in this.packages;
   }
 
   postItemPackageTask(item: IItem, task: IItemTask): Observable<IItemTask> {
     return this.httpClient.post<IItemTask>(`${this.ApiEndpoint()}/api/v1/items/${item.code}/packagetasks`, task);
   }
 }
+
+export function getValidPackages(packageMap: IPackages): {[key: string]: IPackage} {
+  const keys = Object.keys(packageMap);
+  return keys.filter(k => {
+    const packages = packageMap[k]
+      .filter((p) => isValidPackage(p));
+
+    return packages.length > 0;
+  }).reduce((map, key) => {
+    const packages = packageMap[key];
+    const newMap = {...map};
+    newMap[key] = packages.find(p => isValidPackage(p));
+    return newMap;
+  }, {});
+}
+
+export function isValidPackage(pack: IPackage): boolean {
+  const now = new Date(Date.now());
+  const utcToday = Date.UTC(now.getUTCFullYear(),now.getUTCMonth(),now.getUTCDate());
+  return pack !== null && new Date(pack.dataDate).getTime() <= utcToday
+    && (!pack.dataEndDate || new Date(pack.dataEndDate).getTime() >= utcToday);
+}

src/app/landingpage/landingpage.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { TestComponent } from './landingpage.component';
-
-describe('TestComponent', () => {
-  let component: TestComponent;
-  let fixture: ComponentFixture<TestComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ TestComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(TestComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

src/app/menu/menu.component.spec.ts

@@ -1,25 +0,0 @@
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { MenuComponent } from './menu.component';
-
-describe('MenuComponent', () => {
-  let component: MenuComponent;
-  let fixture: ComponentFixture<MenuComponent>;
-
-  beforeEach(async(() => {
-    TestBed.configureTestingModule({
-      declarations: [ MenuComponent ]
-    })
-    .compileComponents();
-  }));
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(MenuComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

src/app/test/test.component.spec.ts

@@ -1,25 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { TestComponent } from './test.component';
-
-describe('TestComponent', () => {
-  let component: TestComponent;
-  let fixture: ComponentFixture<TestComponent>;
-
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
-      declarations: [ TestComponent ]
-    })
-    .compileComponents();
-  });
-
-  beforeEach(() => {
-    fixture = TestBed.createComponent(TestComponent);
-    component = fixture.componentInstance;
-    fixture.detectChanges();
-  });
-
-  it('should create', () => {
-    expect(component).toBeTruthy();
-  });
-});

src/configuration.json

@@ -1,8 +1,8 @@
 {
-    "issuer": "https://accounts.test.farmmaps.eu",
+    "issuer": "http://localhost:8094",
     "clientId": "farmmapsdev",
-    "audience": "http://localhost:8082",
-    "requireHttps": true,
+    "audience": "http://localhost:8082/",
+    "requireHttps": false,
     "apiEndPoint": "http://localhost:8082",
     "grantType":"code"
 }